Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27923
)
Change subject: osmobts: list all features of latest osmobts
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27923/comment/5528374f_d86764e0
PS2, Line 347: * connected yet (thus not sent the feature vector), so we cannot know
for
I think this entire [existing] logic is flawed. […]
My thought process was that with this patch it would at least be consistent between
the BTS models that can and the ones that cannot report the features upon connect. But I
see your point.
How should this be handled then, should we just remove checks in VTY commands against
osmo_bts_has_feature?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27923
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa
Gerrit-Change-Number: 27923
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Apr 2022 10:01:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment