Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32320 )
Change subject: sccp_scoc.c: fix infinite loop on conn ID exhaustion ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/fe4a43ed_5372bcca PS1, Line 17: entire SCCP conn id number space before exiting in failure.
If you want a faster lookup, I think the only way to do this is to move away from a per-instance lin […]
Done
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/3eee7645_fd34777e PS1, Line 551: if (!max_attempts || max_attempts > 0x00FFFFFE) {
I really see no much point in having max_attempts configurable as param here, it should simply be se […]
Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/32320/comment/8442ff6e_b539f079 PS1, Line 589: 0
You forgot to update this call to pass only 1 param.
Done