26 Feb
2026
26 Feb
'26
11:37 a.m.
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email )
Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: In my opinion, if the code calls a function that has *tcap* in the name, and the caller passes something that's not TCAP, it is very much an error. IMHO the problem is more in the caller then? Maybe the caller first needs a is_this_tcap() function followed by calling a tcap_*_rx_* function?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c
Gerrit-Change-Number: 42210
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Feb 2026 10:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No