dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/38941?usp=email )
Change subject: ts_31_102: fix testcase for EF_ePDGSelection
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Unfortunately this fix has a chicken-egg problem. The code looks correct to me. I even
verified one of the testcases with pen and paper. Everything should be correct.
However, the the build failure we see is in the pysim repository and I have fixed the
testcases there now (see
https://gerrit.osmocom.org/c/pysim/+/38941). The problem is that
this of course only works with the fixed version of pyosmocom and the fixed version of
pyosmocom only works with the fixed pysim.
My suggestion would be to remove the pysim test from jenkins.sh as this creates some kind
of a circular dependency. I have inserted a patch before this one that does that, we can
discuss about this in that patch then (see
https://gerrit.osmocom.org/c/python/pyosmocom/+/38942)
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38941?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1
Gerrit-Change-Number: 38941
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Nov 2024 17:46:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes