Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email )
Change subject: [REST] Implement MetricsList ......................................................................
Patch Set 8:
(1 comment)
File contrib/openapi.yaml:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/2b595a30_737c4... : PS8, Line 27: responses:
If the requested metric type is invalid, then such a request is considered invalid and rejected with code 400 Bad Request, because it's violating the present specification. I don't think we want to define general response codes like 400 or 500 for each procedure explicitly.
Acknowledged
Regarding the path... I guess by invalid path you mean a path that matches no metrics in the S1GW. This can be a mistake, e.g. a typo, but this can also happen if the matching metrics are not registered yet. For instance, this applies to per-eNB metrics: they do not exist before the eNB connects. I can implement returning 404 in this case (in a follow-up patch).
That sounds useful IMHO.