[S] Change in osmo-hnbgw[master]: stats: Add per-hnb paging:{cs,ps}:attempted counter

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36209?usp=email ) Change subject: stats: Add per-hnb paging:{cs,ps}:attempted counter ...................................................................... stats: Add per-hnb paging:{cs,ps}:attempted counter Adding counters for number of paging succeeded is much harder, as we currently don't parse connection-oriented DL RANAP and/or any L3 NAS in it. Change-Id: I7648caa410dba8474d57121a8128579ba200b18f --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c 3 files changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index f2982de..bd8a853 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -98,6 +98,9 @@ HNB_CTR_RUA_UDT_UL, HNB_CTR_RUA_UDT_DL, + HNB_CTR_PS_PAGING_ATTEMPTED, + HNB_CTR_CS_PAGING_ATTEMPTED, + HNB_CTR_RAB_ACTIVE_MILLISECONDS_TOTAL, }; diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 055b438..e1bac5f 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -395,6 +395,11 @@ [HNB_CTR_RUA_UDT_DL] = { "rua:unit_data:dl", "Transmitted RUA UnitData (UDT) in downlink" }, + [HNB_CTR_PS_PAGING_ATTEMPTED] = { + "paging:ps:attempted", "Transmitted PS Paging requests" }, + [HNB_CTR_CS_PAGING_ATTEMPTED] = { + "paging:cs:attempted", "Transmitted CS Paging requests" }, + [HNB_CTR_RAB_ACTIVE_MILLISECONDS_TOTAL] = { "rab:cs:active_milliseconds:total", "Cumulative number of milliseconds of CS RAB activity" }, }; diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 9da8377..f9f147b 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -293,6 +293,7 @@ { const char *errmsg; struct hnb_context *hnb; + bool is_ps = cnlink->pool->domain == DOMAIN_PS; errmsg = cnlink_paging_add_ranap(cnlink, imsg); if (errmsg) { @@ -307,6 +308,10 @@ llist_for_each_entry(hnb, &g_hnbgw->hnb_list, list) { if (!hnb->hnb_registered) continue; + if (is_ps) + HNBP_CTR_INC(hnb->persistent, HNB_CTR_PS_PAGING_ATTEMPTED); + else + HNBP_CTR_INC(hnb->persistent, HNB_CTR_CS_PAGING_ATTEMPTED); rua_tx_udt(hnb, data, len); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7648caa410dba8474d57121a8128579ba200b18f Gerrit-Change-Number: 36209 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged