Attention is currently required from: laforge, pespin, daniel, lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32169 )
Change subject: tests: rename and extend gprs_{bvci_default->params}.vty
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Ok, this is a totally new commit after latest version submit, and the discussion doesn't apply anymo […]
I am not following you. This is exactly the same commit with exactly the same change ID, I simply removed the statements about the local port being 0 is wrong and about sane defaults...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32169
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia02e9a97137eb7724f22526fc3768331b35ac55d
Gerrit-Change-Number: 32169
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 31 Mar 2023 14:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment