Attention is currently required from: neels, fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
......................................................................
Patch Set 3:
(1 comment)
File src/libosmo-pfcp/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/cb181f7f_b21bda77
PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS
> I presume LDFLAGS and LDADD are the same thing,
one replaces the earlier LDFLAGS and the other doe […]
for the record: fixeria is
correct; LDFLAGS and LIBS are separate things, and have always been for as long as I can
remember.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
Gerrit-Change-Number: 31741
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Mar 2023 09:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment