Attention is currently required from: daniel, fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842?usp=email )
Change subject: logging: Improve GSMTAP log documentation ......................................................................
Patch Set 2:
(7 comments)
File common/chapters/logging.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/6171dacd_4ef7a... : PS2, Line 239: I just tested it with osmo-mgw and it works as described in the section you have deleted: * when starting with either the default config or the default config with no `log` section, it logs to stderr by default (in both cases) * `logging level force-all fatal` works to set the log output to a minimum
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/e9f3bbf9_13e4b... : PS2, Line 233: syncrhonous ```suggestion the GSMTAP source socket as non-blocking, and attempt synchronous write ```
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/67f68f40_62214... : PS2, Line 238: blocking mode, and attempt syncrhonous write to the UDP socket, blocking ```suggestion blocking mode, and attempt synchronous write to the UDP socket, blocking ```
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/ddf6c631_171f0... : PS2, Line 242: the thread for an un specified (potentially long or event infinite) ```suggestion the thread for an un specified (potentially long or even infinite) ```
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/76c8b211_a3729... : PS2, Line 250: asyncrhonous ```suggestion GSMTAP source socket as non-blocking, and attempt asynchronous write to ```
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/eb5a46e2_ba2a0... : PS2, Line 255: , messages ```suggestion buffer *and* the GSMTAP log target workqueue are full. This ```
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41842/comment/77c9ae91_08e89... : PS2, Line 260: mode ```suggestion In any of the I/O modes above, the UDP socket send buffer size of the GSMTAP log ```