Attention is currently required from: pespin, fixeria.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/30616 )
Change subject: ipa: Add ipa_client_conn_open2 with connect timeout argument
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/abis/ipa.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/e1f2cb0c_8e104caa
PS3, Line 108: int ipa_client_conn_open2(struct ipa_client_conn *link, int
connect_timeout);
unsigned int connect_timeout
Done
File src/input/ipa.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30616/comment/e1855879_8a7ae548
PS2, Line 136: osmo_timer_del(&link->timer);
Ah I see, better add a comment innside the if block
above, soemthing like "/* link->timer is deleted […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/30616
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaeb672a4c981e9769443fb0cd6c8e59cb76307bd
Gerrit-Change-Number: 30616
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 14:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment