Attention is currently required from: pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33221 )
Change subject: stream: Update log messages
......................................................................
Patch Set 4:
(3 comments)
File src/stream.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/e96bef04_061cb090
PS3, Line 564: LOGSCLI(cli, LOGL_DEBUG, "connection established.\n");
Ack
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/89453528_85c6520d
PS3, Line 1605: LOGP(DLINP, LOGL_NOTICE, "Connection is being flushed and closed;
ignoring received message\n");
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33221/comment/e7c6cd00_cbce7238
PS3, Line 1710: if (conn == NULL)
I'd rather keep it like this. We already return NULL below if osmo_fd_register fails.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33221
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ife20b9d18e6ca86a06991d68165694e31052c58a
Gerrit-Change-Number: 33221
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jun 2023 13:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment