Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email )
Change subject: testenv: add test environment script
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS3:
1+1=2
File _testenv/data/podman/Dockerfile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/f3a1d93c_6425a...
PS3, Line 78: ENV USE_CCACHE=0
shouldn't you move this further down until it is used? otherwise all the steps below are rerun if on […]
CCACHE is enabled on demand when running commands inside the container by setting the environment variable, not by changing it here in the Dockerfile. It is not useful to have it enabled while building the image since we don't build any of the testsuite or SUT code while building the image.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2
Gerrit-Change-Number: 37694
Gerrit-PatchSet: 3
Gerrit-Owner: osmith
osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 02 Aug 2024 13:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
