Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31033 )
Change subject: Add L1 signals to misdn driver ......................................................................
Patch Set 4:
(2 comments)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/fa3f8a42_54149716 PS3, Line 636: mph_information_ind(line, *((int *)msg->data));
same. […]
I think you forgot to change this one to uint32_t
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/31033/comment/e550825a_921c05ac PS4, Line 111: isd.sa_bits & 1, (isd.sa_bits >> 1) & 1, (isd.sa_bits >> 2) & 1, (isd.sa_bits >> 3) & 1, usually indentation goes at the same column after function's "(" char.
get_value_string(e1inp_signal_names, S_L_INP_LINE_SA_BITS), isd.sa_bits & 1, (isd.sa_bits >> 1) & 1, (isd.sa_bits >> 2) & 1, (isd.sa_bits >> 3) & 1,