Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33308 )
Change subject: mgcp-client: Add keepalive feature ......................................................................
Patch Set 4:
(2 comments)
File src/libosmo-mgcp-client/mgcp_client_vty.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/d149e7bc_bb7d2e6d PS4, Line 311: "Monitor if the MGCP link against MGW is still usable\n" Maybe "Monitor MGW availability", or: "Monitor whether the MGCP link towards the MGW is still usable\n"
https://gerrit.osmocom.org/c/osmo-mgw/+/33308/comment/8ea01e57_de3a6537 PS4, Line 676: pool_member->clien
not sure if it really benefits from operational point of view, since the MGW in UNKNOWN state should […]
I would use available / unavailable here. When keepalive is not enabled I would display something like "(not monitored)"