Attention is currently required from: Hoernchen, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30612 )
Change subject: trxcon: allow extending FBSB timeout (quirks for slow PHYs) ......................................................................
Patch Set 2:
(2 comments)
File src/host/trxcon/src/trxcon_main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/a5d72fff_35bab365 PS2, Line 71: int phyq_fbsb_extend_fns; unsigned? this cannot be negative right?
https://gerrit.osmocom.org/c/osmocom-bb/+/30612/comment/a3a638a0_47b1c379 PS2, Line 243: app_data.phyq_fbsb_extend_fns = atoi(optarg); ah so you are declaring it as an int just in order to be able to use atoi. What about declaring it as unsigned and using strtoul here instead?