Attention is currently required from: fixeria, neels, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email )
Change subject: build config: add --disable-ortp option
......................................................................
Patch Set 2:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/libosmo-abis/+/36975/comment/eea85380_2cc3418c
PS2, Line 150: _cflags_save=$CFLAGS
I believe these API quirks should not be executed if `ENABLE_ORTP = no`?
You are right, thanks for the catch! The current patch works in that the build passes with --disable-ortp and no ortp present, but those now-bogus tests still run, setting variables which then remain unused.
I will revise my patch to conditionalize the tests in question.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883
Gerrit-Change-Number: 36975
Gerrit-PatchSet: 2
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 26 Jun 2024 16:13:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
