Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29975 )
Change subject: Support building with -Werror=strict-prototypes /
-Werror=old-style-definition
......................................................................
Patch Set 2:
(3 comments)
File include/osmocom/vty/command.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686):
https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/b72cc5e2_4d65ddf9
PS2, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status);
"foo * bar" should be "foo *bar"
File src/select.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686):
https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/48c489c7_8692e5a8
PS2, Line 669: bool osmo_select_shutdown_done(void) {
open brace '{' following function definitions go on the next line
File src/vty/cpu_sched_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686):
https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/62f56d39_6a50fb60
PS2, Line 92: static int get_num_cpus(void) {
open brace '{' following function definitions go on the next line
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29975
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2
Gerrit-Change-Number: 29975
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 03 Nov 2022 10:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment