[S] Change in osmo-s1gw[master]: sctp_{server,proxy}: cosmetic: improve logging

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email ) Change subject: sctp_{server,proxy}: cosmetic: improve logging ...................................................................... sctp_{server,proxy}: cosmetic: improve logging Change-Id: I6287a5ec775e3aba18e16470388888c43104e963 --- M src/sctp_proxy.erl M src/sctp_server.erl 2 files changed, 17 insertions(+), 8 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 2cc6165..ffa9111 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -119,7 +119,7 @@ %% Handle an #sctp_sndrcvinfo event (MME -> eNB data) connected(info, {sctp, _Socket, MmeAddr, MmePort, {[#sctp_sndrcvinfo{assoc_id = Aid}], Data}}, S) -> - logger:info("MME connection (id=~p, ~p:~p) Rx ~p", + logger:debug("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), sctp_server:send_data(maps:get(enb_aid, S), s1ap_proxy:handle_pdu(Data)), diff --git a/src/sctp_server.erl b/src/sctp_server.erl index a2b722a..c55c27d 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -118,17 +118,17 @@ assoc_id = Aid}}) -> case ConnState of comm_up -> - logger:notice("Connection (id=~p, ~p:~p) established", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) established", [Aid, FromAddr, FromPort]), Clients = client_add(State#server_state.clients, Aid, FromAddr, FromPort, State#server_state.mme_addr_port); shutdown_comp -> - logger:notice("Connection (id=~p, ~p:~p) closed", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) closed", [Aid, FromAddr, FromPort]), Clients = client_del(State#server_state.clients, Aid); comm_lost -> - logger:notice("Connection (id=~p, ~p:~p) lost", [Aid, FromAddr, FromPort]), + logger:notice("eNB connection (id=~p, ~p:~p) lost", [Aid, FromAddr, FromPort]), Clients = client_del(State#server_state.clients, Aid); _ -> - logger:notice("Connection (id=~p, ~p:~p) state ~p", + logger:notice("eNB connection (id=~p, ~p:~p) state ~p", [Aid, FromAddr, FromPort, ConnState]), Clients = State#server_state.clients end, @@ -137,12 +137,12 @@ %% Handle an #sctp_sndrcvinfo event (incoming data) sctp_recv(State, {FromAddr, FromPort, [#sctp_sndrcvinfo{assoc_id = Aid}], Data}) -> - logger:info("Connection (id=~p, ~p:~p) Rx ~p", [Aid, FromAddr, FromPort, Data]), + logger:debug("eNB connection (id=~p, ~p:~p) -> MME: ~p", [Aid, FromAddr, FromPort, Data]), case dict:find(Aid, State#server_state.clients) of {ok, #client_state{pid = Pid}} -> sctp_proxy:send_data(Pid, Data); error -> - logger:error("Connection (id=~p, ~p:~p) is not known to us?!?", + logger:error("eNB connection (id=~p, ~p:~p) is not known to us?!?", [Aid, FromAddr, FromPort]) end, State; @@ -194,7 +194,7 @@ close_conns(Sock, [{Aid, Client} | Clients]) -> {FromAddr, FromPort} = Client#client_state.addr_port, - logger:notice("Terminating connection (id=~p, ~p:~p)", [Aid, FromAddr, FromPort]), + logger:notice("Terminating eNB connection (id=~p, ~p:~p)", [Aid, FromAddr, FromPort]), %% request to terminate an MME connection sctp_proxy:shutdown(Client#client_state.pid), %% gracefully close an eNB connection -- To view, visit https://gerrit.osmocom.org/c/osmo-s1gw/+/37068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6287a5ec775e3aba18e16470388888c43104e963 Gerrit-Change-Number: 37068 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged