12 Jan
2023
12 Jan
'23
10:59 a.m.
Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30890 )
Change subject: gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instance ......................................................................
Patch Set 2:
(1 comment)
File src/sgsn/gtp_ggsn.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/30890/comment/9cd1cf09_4d297f10 PS2, Line 87: struct sgsn_instance *sgsn
I am wondering how this function worked before you added the sgsn pointer? […]
yes, sgsn is actually a global variable too. I plan to perhaps submit an extra commit at the end renaming it to g_sgsn.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30890
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 12 Jan 2023 09:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment