12 Nov
2024
12 Nov
'24
1:53 p.m.
Attention is currently required from: JPM, dexter.
laforge has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )
Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS1:
The failing tests are from project (pysim) using pyosmocom. Those test are wrong as 3GPP TS 24. […]
Agreed; we can manually override the V+1 once the code review has reached 2.
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
Gerrit-Change-Number: 38687
Gerrit-PatchSet: 5
Gerrit-Owner: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: JPM jean-pierre.marcotte.1@ens.etsmtl.ca
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Tue, 12 Nov 2024 12:53:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: JPM jean-pierre.marcotte.1@ens.etsmtl.ca