Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33292 )
Change subject: ASCI: VGCS/VBS RACH -> RSL TALKER/LISTENER DETECT
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Patchset:
PS6:
Looks good to me in general!
File src/common/asci.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/ed403d71_cf39eddc
PS6, Line 79: is in not active
This looks weird, maybe just "is not active"?
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33292/comment/248c2b69_9baf1802
PS6, Line 1988: handover
Change to "DCCH"? The function actually expects a channel type name, not type of
access.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33292
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1bd07ab6802341b09a06e89df356665ffaf6d2bf
Gerrit-Change-Number: 33292
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Jul 2023 13:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment