Attention is currently required from: osmith.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27928 )
Change subject: abis_nm: tweak unknown feature check
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/osmo-bsc/abis_nm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27928/comment/5e8a5bcf_bfdcf5ad
PS1, Line 601: Frep
Frep is here intentionally, because the feature vector is always aligned to N * 8 bits, so
there can be padding bits (zeroes) and we should not treat them as unknown features. See
the loop condition above: i < len * 8.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27928
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iabe016b6dca54492bf177ac84fda4357b5be404d
Gerrit-Change-Number: 27928
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 15:30:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment