Attention is currently required from: fixeria, jolly, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )
Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
To me it's even clearer now that these structs and related APIs are not really needed. […]
I guess I agree in general, but I'm not aware we've so far developed some kind of standard/generic "struct l8v { uint8_t len; uint8_t buf[0] } __attribute__((packed));" which we could use everywhere.
Given that in this case we're actually talking about TLV, I agree that having the user use the msgb API directly is likely the best approach.
Random thought: Rather than adding raw GSM 04.08 IEs to the end of MNCC, we might want to consider wrapping that in another "container" IE to avoid any overlaps between MNCC definitions and GSM 04.08 definitions?