Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/28704 )
Change subject: Use cbc_{cbsp,sbcap}_link_close when possible
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/cbsp_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28704/comment/812656ea_f2a13665
PS1, Line 155: cbc_cbsp_link_close(link);
Unrelated: looks like we leak memory here. I think we need to:
osmo_fsm_inst_free(link->fi);
llist_del(&link->list);
talloc_free(link);
before returning -1.
File src/sbcap_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28704/comment/251e47ca_e8742672
PS1, Line 183: cbc_sbcap_link_close(link);
Same memleak problem here as in cbsp_cbc_accept_cb().
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28704
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ie020b9b5ee93ae8d0c9e7266177728185e8635f2
Gerrit-Change-Number: 28704
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Jul 2022 00:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment