Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27644 )
Change subject: rsl: Fix tlv_parse of IPAC_DLCX_IND message
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File tests/abis/abis_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/27644/comment/5147b6f8_c71d0748
PS1, Line 196: SYS#5915
Same here.
https://gerrit.osmocom.org/c/libosmocore/+/27644/comment/9db29ae8_df6cedf4
PS1, Line 251: sys5915
I don't think it's a good idea to use/mention Sysmocom's internal ticket
numbers in the code, because for those who have no access to the internal Redmine it
basically means nothing. I would rather call it test_dec_ipac_dlc_ind().
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27644
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib637197ef3508ec94aec05d08d4e6aa15ddea055
Gerrit-Change-Number: 27644
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Apr 2022 22:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment