Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271?usp=email )
Change subject: hnbgw: Introduce altstep as_pfcp_handle_del_req() ......................................................................
Patch Set 1:
(2 comments)
File hnbgw/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271/comment/38464fcd_b1f48... : PS1, Line 998: PFCP.receive(PDU_PFCP:?)
This catch-all `. […]
I don't see a problem with this tbh, this is how it will be used so far. If later on we want to use it in some other way we can change it.
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271/comment/b5380fc4_243ac... : PS1, Line 1545: as_pfcp_handle_del_req
Potential side-effect: the new altstep is doing `f_PFCPEM_unsubscribe_seid()`, which was not here be […]
That's fine, the other tests was simply no calling this but it's actually more correct to call it like the altstep does.