Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 )
Change subject: add pfcp_endpoint ......................................................................
Patch Set 4:
(1 comment)
File include/osmocom/pfcp/pfcp_endpoint.h:
https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/d8acc337_fb25e285 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx;
there are various function pointers in osmocom code that are not named *_cb, […]
General comment: Pointing to historical mistakes is never a good reason not to improve new code. _ops is a container for multiple callback functions (operations), so it doesn't apply. e1inp_driver and call_leg are rather ancient examples, where of course we cannot fix it now without API breakage, which we clearly don't want.