Attention is currently required from: iedemam, neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
)
Change subject: WIP: New stats for lchan life duration.
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Hi all, […]
I'm fine with tracking
milliseconds, I'm not saying you should change that. I'm mentioning that I think
showing milliseconds *in the VTY output* is not needed and makes stuff more difficult to
read. Since VTY is to be read by a person, there's no need to see milliseconds there,
and only makes it more difficult to quickly understand the duration.
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/f1f580c2_b626457c
PS4, Line 3830: vty_out(vty, " Channel Activations : %"PRIu64"
TCH", activations_tch);
You don't want to show total activations? Same
comment as above about ms precision being needed to d […]
Uhm sounds like I missed
that part, I was just focusing on the formatting. It's probably something liek this
then right?
Channel Activations:
TCH 43534 (avg lifespan 3s)
SDCCH 3214123 (avg lifespan 5s)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 5
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 08 Feb 2022 17:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment