Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email )
Change subject: rtp2trau_hr16: set D bits correctly ......................................................................
Patch Set 1:
(1 comment)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/37150/comment/94295314_fe5bd3e9 PS1, Line 428: osmo_pbit2ubit(tf->d_bits, data, 112);
where does this 112 come from?
It is the number of bits in a GSM-HR codec frame. In the opposite direction (osmo_ubit2pbit() call in trau2rtp_hr16()) the existing code already used this raw number 112 prior to my changes, hence I thought it was OK. But if having a raw number like this in here is bad, what should I change it to? I don't see any definitions in Osmocom headers for number of bits in the frame of different codecs - should I put GSM_HR_BYTES*8 in here?