Attention is currently required from: pespin.

View Change

1 comment:

• File src/trau/trau_rtp_conv.c:

  • Patch Set #1, Line 428: osmo_pbit2ubit(tf->d_bits, data, 112);

    where does this 112 come from?

    It is the number of bits in a GSM-HR codec frame. In the opposite direction (osmo_ubit2pbit() call in trau2rtp_hr16()) the existing code already used this raw number 112 prior to my changes, hence I thought it was OK. But if having a raw number like this in here is bad, what should I change it to? I don't see any definitions in Osmocom headers for number of bits in the frame of different codecs - should I put GSM_HR_BYTES*8 in here?

To view, visit change 37150. To unsubscribe, or for help writing mail filters, visit settings.