Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email )
Change subject: construct: allow stripping of leading zeros with StripTrailerAdapter
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
please implement this as a new adapter. The name "StripTrailer" indicates it is
about stripping something at the end. If you want to strip something from the front, you
can add a new "StripHeader" class. You can also share some code in a newly
created shared baseclass from which both StripHeader and StripTrailer inherit.
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6
Gerrit-Change-Number: 39193
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Dec 2024 17:07:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes