Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/32399
)
Change subject: Move out of alloc_algo code modifying the data model
......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/61b5465a_43ad7333
PS7, Line 10: abck
back
Ack
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/46d445a6_3e7321c1
PS7, Line 15: responisble
responsible
Ack
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/1afd08df_f6e8e7a4
PS7, Line 16: allocat
allocate
Ack
File src/alloc_algo.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/75fb95fe_4108c660
PS7, Line 310: * \param[in] req Contains all the requested params
add res to the description here? same 2x below
Ack
File src/tbf.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/04d5c806_fa332274
PS7, Line 588:
missing " and "
I'll add a comma.
It's not really "and", it's more a cause->consequence or equal
thing.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32399
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
Gerrit-Change-Number: 32399
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Apr 2023 11:21:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment