Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39661?usp=email )
Change subject: stp: Fix brokeness in STP_Tests_IPA.TC_tmt_loadshare
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39661/comment/d65d5098_563b…
:
PS2, Line 272: f_vty_config2(VTY, {"cs7 instance 0", "as " &
mp_ipa_as_names[2] & " ipa"}, "traffic-mode loadshare");
How about resetting this in f_init_ipa()? Otherwise with Misc_Helpers.f_shutdown() it
won't be reset if this test runs into an error condition, which may lead to following
tests failing.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39661?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I61c3efbf8e30533d051e2de506f7c8eaae7e297b
Gerrit-Change-Number: 39661
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Mar 2025 13:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes