Attention is currently required from: arehbein, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31049 )
Change subject: llc: Initial support for GRR-UNITDATA.ind/req ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/llc/llc.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/aab33607_72516f8b PS2, Line 315: gprs_llc_prim_alloc_grr_unitdata_req(lle->llme->tlli, NULL, 4096 - sizeof(llc_prim))
I still prefer the way I added it, it allows for much easier extension of code later if we need to d […]
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/31049/comment/2a79f8c0_0c7951e2 PS2, Line 758: llc_prim_tx->ll.unitdata_ind.apply_gea = !drop_cipherable; /* TODO: is this correct? */
In this specific case, I'm merely moving this code, so I'm basically touching nothing here. […]
Done