19 Sep
2022
19 Sep
'22
8:21 p.m.
Attention is currently required from: msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ......................................................................
Patch Set 22: Code-Review-1
(1 comment)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/2d0c3524_fca086cc PS21, Line 14: esme
Done
what is happening here? I ask a question, you mark as Done without responding; i ask your feedback again, you mark as Done again without responding. This is not acceptable handling of code review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 22
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: msuraev msuraev@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 19 Sep 2022 10:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: msuraev msuraev@sysmocom.de
Gerrit-MessageType: comment