Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34222 )
Change subject: add the gnuradio 3.10 demodulator and receiver from telive ......................................................................
Patch Set 1:
(10 comments)
File src/demod/simdemod3.grc:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/907f8b95_ff04ed2c PS1, Line 13: (this option is disabled for the version commited to osmo-tetra) 'commited' may be misspelled - perhaps 'committed'?
File src/demod/simdemod3.py:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/bc3cb04f_510d8d85 PS1, Line 10: # Description: cqpsk demodulator for tetra. based on pi4dqpsk_rx.grc (by 'Luca Bortolotti' @optiluca) from https://gitlab.com/larryth/tetra-kit/ . It is meant as a replacement for simdemod2.py, taked the data from stdin, and dumpd demodulated data to STDOUT. Also sends via UDP the information how much the signal is mistuned (this option is disabled for the version commited to osmo-tetra) 'commited' may be misspelled - perhaps 'committed'?
File src/receiver1udp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/0d913b28_c483dfff PS1, Line 5: # This is an example how to get I/Q data via udp packets, trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/5898f9b6_99003535 PS1, Line 32: 3.6) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/38e0c874_bd7b80b6 PS1, Line 36: 3.7) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/b3090d65_41bbd6b9 PS1, Line 40: 3.10) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/6ff7624f_4d027df3 PS1, Line 44: *) trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/ce071c39_1bb3d4c7 PS1, Line 45: echo "Unsuported gnuradio version $GR_VERSION" 'Unsuported' may be misspelled - perhaps 'Unsupported'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/6e7e8094_5c879547 PS1, Line 62: socat -b 4096 UDP-RECV:${UDP_PORT} STDOUT | demod/simdemod2.py -o /dev/stdout -i /dev/stdin | ./float_to_bits -a /dev/stdin /dev/stdout | ./tetra-rx /dev/stdin trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10691): https://gerrit.osmocom.org/c/osmo-tetra/+/34222/comment/e9bce98e_033b7e02 PS1, Line 68: echo "Dont know how to handle pythin version [$PYT]" trailing whitespace