pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcap/+/26895 )
Change subject: server: Add vty command file-permission-mask
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/c/osmo-pcap/+/26895/3/src/osmo_server_vty.c
File src/osmo_server_vty.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/26895/3/src/osmo_server_vty.c@148
PS3, Line 148: switch (errno) {
agreed
It's probably true, but since strtoul
is quite a complex beast, I prefer keeping this way so that it can be compared more easily
to what the man page description states.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/26895
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I78e0b56b38de438ee5fb679ae41c65b02ea2e722
Gerrit-Change-Number: 26895
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: zecke <holger(a)freyther.de>
Gerrit-Comment-Date: Thu, 13 Jan 2022 09:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment