Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email )
Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ......................................................................
Patch Set 5:
(13 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/1238f249_7c9476c7?usp... : PS5, Line 2568: if (mmctx) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/9f02ca19_288fda55?usp... : PS5, Line 2597: if (!mme) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/46fd05d2_0e18125e?usp... : PS5, Line 2627: } else { else is not generally useful after a break or return
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/31a61cde_fed7afca?usp... : PS5, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ee74b591_a8708167?usp... : PS5, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7823cf6c_dfe4725c?usp... : PS5, Line 913: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cb0c2899_e98cefa0?usp... : PS5, Line 918: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/4ab08d9e_c35fc2c1?usp... : PS5, Line 918: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/813e5550_7a9e0db8?usp... : PS5, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/64992965_9edc7c9c?usp... : PS5, Line 1125: if (buf_len <= 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f9a6cf47_ec722257?usp... : PS5, Line 1139: // break; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/a7c5c1c0_31f04715?usp... : PS5, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21579): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/7f4a4342_0abfd42f?usp... : PS5, Line 1388: if (rc) { braces {} are not necessary for single statement blocks