Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email )
Change subject: sctp_proxy: use lists:filter/2 in sctp_send_pending/2
......................................................................
Patch Set 1:
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616/comment/a7e7a7ad_97653... :
PS1, Line 307: lists:reverse(Pending)),
why this reverse? Are you adding them to the tx_queue in reverse order? ie prepending messages?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic666fd77bc6d04341f3c57140dea5d4a5e616e80
Gerrit-Change-Number: 41616
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 05 Dec 2025 17:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No