Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email )
Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2 ......................................................................
Patch Set 1:
(1 comment)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39385/comment/8fd035ff_8f8ebc2d?u... : PS1, Line 142: static int srvc_ipa_segmentation_cb2(struct osmo_stream_cli *cli, struct msgb *msg) : { : return osmo_ipa_segmentation_cb(msg); : } : it's not really elegant that this API improvement now requires us to sprkinkle boilerplate code like this across every user of libosmo-sigtran.
I don't have time to think about this further or think about solutions, just sharing my dissatisfaction when I see changes introducing new APIs that require more boilerplate.