Attention is currently required from: dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/31269
)
Change subject: mgcp_e1: be more frugal withe E1 line resources
......................................................................
Patch Set 1:
(4 comments)
File src/libosmo-mgcp/mgcp_e1.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/5c2fa12e_3a922ca0
PS1, Line 370: subslot
subslots
https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/880fd076_c080c899
PS1, Line 371: belos
below
https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/3550cd26_229975c6
PS1, Line 432: LOGL_INFO
* if this shouldn't happen, maybe LOGL_ERROR?
* maybe don't return 0?
https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/bd6f9201_867dd473
PS1, Line 657: urad against multiple calls. In case we do
Guard, don't?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/31269
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058
Gerrit-Change-Number: 31269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 09:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment