Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email )
Change subject: personalization: refactor SmspTpScAddr ......................................................................
Patch Set 1:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/41779/comment/cff9854e_eccc28d3?usp=ema... : PS1, Line 362: val must be a tuple (international[bool], digits[str]) this should be given as type annotation instead of a comment. I realize that the original code didn't have it, but if you're adding that missing annotation, please do it in a way that benefits both linters and the human developer instead of just the latter.