[M] Change in osmo-mgw[master]: mgw: MDCX: Split mgcp header pars parsing into a previous step

Attention is currently required from: daniel, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email ) Change subject: mgw: MDCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 4: (1 comment) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/b3b90472_372b7ffb?usp… : PS4, Line 1115: /* Reset conn mode in case it was tweaked through VTY: */ Yeah, something else which kinda sucks a bit: $ ag "\->mode" | grep vty src/libosmo-mgcp/mgcp_vty.c:1374: conn->mode = MGCP_CONN_LOOPBACK; src/libosmo-mgcp/mgcp_vty.c:1376: conn->mode = conn->mode_orig; See VTY command "loop-endpoint <0-64> NAME (0|1)". Again, something I cannot really solve/improve in this patch, too many refactoring already. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6ecb41fc2cc737c3a161b6bc98bd08ae01909655 Gerrit-Change-Number: 39239 Gerrit-PatchSet: 4 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 15 Jan 2025 17:33:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;