15 Sep
2025
15 Sep
'25
12:32 p.m.
Attention is currently required from: daniel, osmith, pespin.
Hello Jenkins Builder, daniel, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review-1 by pespin, Verified+1 by daniel
Change subject: Regenerate code with newer asn1c
......................................................................
Regenerate code with newer asn1c
asn1c used from: https://github.com/mouse07410/asn1c
branch: vlm_master
commit: 2c06555 ("Fix #239 by applying suggested fix")
This no longer uses/requires libasn1c so drop the dependency and modify
the build system similar to osmo-cbc/src/sbcap/
Tweaked-By: Oliver Smith <osmith(a)sysmocom.de>
Related: SYS#5423
Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
---
A .checkpatch.conf
M Makefile.am
M configure.ac
M contrib/jenkins.sh
D include/AARE-apdu.h
D include/AARQ-apdu.h
D include/ABRT-apdu.h
D include/ABRT-source.h
D include/AUDT-apdu.h
D include/Abort.h
D include/Associate-result.h
D include/Associate-source-diagnostic.h
D include/Begin.h
D include/Component.h
D include/ComponentPortion.h
D include/Continue.h
D include/DestTransactionID.h
D include/Dialog1.h
D include/DialogueOC.h
D include/DialoguePDU.h
D include/DialoguePortion.h
D include/ERROR.h
D include/EXTERNAL.h
D include/End.h
D include/ErrorCode.h
D include/ExternalPDU.h
D include/GeneralProblem.h
D include/Invoke.h
D include/InvokeIdType.h
D include/InvokeProblem.h
M include/Makefile.am
D include/OPERATION.h
D include/OrigTransactionID.h
D include/P-AbortCause.h
D include/Parameter.h
D include/RLRE-apdu.h
D include/RLRQ-apdu.h
D include/Reason.h
D include/Reject.h
D include/Release-request-reason.h
D include/Release-response-reason.h
D include/ReturnError.h
D include/ReturnErrorProblem.h
D include/ReturnResult.h
D include/ReturnResultProblem.h
D include/TCMessage.h
D include/UniDialoguePDU.h
D include/Unidirectional.h
A include/osmocom/Makefile.am
A include/osmocom/tcap/ANY.h
A include/osmocom/tcap/BIT_STRING.h
A include/osmocom/tcap/GraphicString.h
A include/osmocom/tcap/INTEGER.h
A include/osmocom/tcap/Makefile.am
A include/osmocom/tcap/NULL.h
A include/osmocom/tcap/NativeInteger.h
A include/osmocom/tcap/OBJECT_IDENTIFIER.h
A include/osmocom/tcap/OCTET_STRING.h
A include/osmocom/tcap/OPEN_TYPE.h
A include/osmocom/tcap/ObjectDescriptor.h
A include/osmocom/tcap/TCAP_AARE-apdu.h
A include/osmocom/tcap/TCAP_AARQ-apdu.h
A include/osmocom/tcap/TCAP_ABRT-apdu.h
A include/osmocom/tcap/TCAP_ABRT-source.h
A include/osmocom/tcap/TCAP_AUDT-apdu.h
A include/osmocom/tcap/TCAP_Abort.h
A include/osmocom/tcap/TCAP_Associate-result.h
A include/osmocom/tcap/TCAP_Associate-source-diagnostic.h
A include/osmocom/tcap/TCAP_Begin.h
A include/osmocom/tcap/TCAP_Component.h
A include/osmocom/tcap/TCAP_ComponentPortion.h
A include/osmocom/tcap/TCAP_Continue.h
A include/osmocom/tcap/TCAP_DestTransactionID.h
A include/osmocom/tcap/TCAP_Dialog1.h
A include/osmocom/tcap/TCAP_DialoguePDU.h
A include/osmocom/tcap/TCAP_DialoguePortion.h
A include/osmocom/tcap/TCAP_ERROR.h
A include/osmocom/tcap/TCAP_EXTERNAL.h
A include/osmocom/tcap/TCAP_End.h
A include/osmocom/tcap/TCAP_ErrorCode.h
A include/osmocom/tcap/TCAP_ExternalPDU.h
A include/osmocom/tcap/TCAP_GeneralProblem.h
A include/osmocom/tcap/TCAP_Invoke.h
A include/osmocom/tcap/TCAP_InvokeIdType.h
A include/osmocom/tcap/TCAP_InvokeProblem.h
A include/osmocom/tcap/TCAP_OPERATION.h
A include/osmocom/tcap/TCAP_OrigTransactionID.h
A include/osmocom/tcap/TCAP_P-AbortCause.h
A include/osmocom/tcap/TCAP_Parameter.h
A include/osmocom/tcap/TCAP_RLRE-apdu.h
A include/osmocom/tcap/TCAP_RLRQ-apdu.h
A include/osmocom/tcap/TCAP_Reason.h
A include/osmocom/tcap/TCAP_Reject.h
A include/osmocom/tcap/TCAP_Release-request-reason.h
A include/osmocom/tcap/TCAP_Release-response-reason.h
A include/osmocom/tcap/TCAP_ReturnError.h
A include/osmocom/tcap/TCAP_ReturnErrorProblem.h
A include/osmocom/tcap/TCAP_ReturnResult.h
A include/osmocom/tcap/TCAP_ReturnResultProblem.h
A include/osmocom/tcap/TCAP_TCMessage.h
A include/osmocom/tcap/TCAP_UniDialoguePDU.h
A include/osmocom/tcap/TCAP_Unidirectional.h
A include/osmocom/tcap/TCAP_asn_constant.h
A include/osmocom/tcap/asn_SEQUENCE_OF.h
A include/osmocom/tcap/asn_SET_OF.h
A include/osmocom/tcap/asn_application.h
A include/osmocom/tcap/asn_bit_data.h
A include/osmocom/tcap/asn_codecs.h
A include/osmocom/tcap/asn_codecs_prim.h
A include/osmocom/tcap/asn_config.h
A include/osmocom/tcap/asn_internal.h
A include/osmocom/tcap/asn_ioc.h
A include/osmocom/tcap/asn_random_fill.h
A include/osmocom/tcap/asn_system.h
A include/osmocom/tcap/ber_decoder.h
A include/osmocom/tcap/ber_tlv_length.h
A include/osmocom/tcap/ber_tlv_tag.h
A include/osmocom/tcap/constr_CHOICE.h
A include/osmocom/tcap/constr_SEQUENCE.h
A include/osmocom/tcap/constr_SEQUENCE_OF.h
A include/osmocom/tcap/constr_SET_OF.h
A include/osmocom/tcap/constr_TYPE.h
A include/osmocom/tcap/constraints.h
A include/osmocom/tcap/der_encoder.h
M libosmo-asn1-tcap.pc.in
A move-asn1-header-files.sh
D src/AARE-apdu.c
D src/AARQ-apdu.c
D src/ABRT-apdu.c
D src/ABRT-source.c
D src/AUDT-apdu.c
D src/Abort.c
D src/Associate-result.c
D src/Associate-source-diagnostic.c
D src/Begin.c
D src/Component.c
D src/ComponentPortion.c
D src/Continue.c
D src/DestTransactionID.c
D src/Dialog1.c
D src/DialogueOC.c
D src/DialoguePDU.c
D src/DialoguePortion.c
D src/ERROR.c
D src/End.c
D src/ErrorCode.c
D src/ExternalPDU.c
D src/GeneralProblem.c
D src/Invoke.c
D src/InvokeIdType.c
D src/InvokeProblem.c
M src/Makefile.am
D src/OPERATION.c
D src/OrigTransactionID.c
D src/P-AbortCause.c
D src/Parameter.c
D src/RLRE-apdu.c
D src/RLRQ-apdu.c
D src/Reason.c
D src/Reject.c
D src/Release-request-reason.c
D src/Release-response-reason.c
D src/ReturnError.c
D src/ReturnErrorProblem.c
D src/ReturnResult.c
D src/ReturnResultProblem.c
D src/TCMessage.c
D src/UniDialoguePDU.c
D src/Unidirectional.c
A src/gen/TCAP_AARE-apdu.c
A src/gen/TCAP_AARQ-apdu.c
A src/gen/TCAP_ABRT-apdu.c
A src/gen/TCAP_ABRT-source.c
A src/gen/TCAP_AUDT-apdu.c
A src/gen/TCAP_Abort.c
A src/gen/TCAP_Associate-result.c
A src/gen/TCAP_Associate-source-diagnostic.c
A src/gen/TCAP_Begin.c
A src/gen/TCAP_Component.c
A src/gen/TCAP_ComponentPortion.c
A src/gen/TCAP_Continue.c
A src/gen/TCAP_DestTransactionID.c
A src/gen/TCAP_Dialog1.c
A src/gen/TCAP_DialoguePDU.c
A src/gen/TCAP_DialoguePortion.c
A src/gen/TCAP_ERROR.c
A src/gen/TCAP_EXTERNAL.c
A src/gen/TCAP_End.c
A src/gen/TCAP_ErrorCode.c
A src/gen/TCAP_ExternalPDU.c
A src/gen/TCAP_GeneralProblem.c
A src/gen/TCAP_Invoke.c
A src/gen/TCAP_InvokeIdType.c
A src/gen/TCAP_InvokeProblem.c
A src/gen/TCAP_OPERATION.c
A src/gen/TCAP_OrigTransactionID.c
A src/gen/TCAP_P-AbortCause.c
A src/gen/TCAP_Parameter.c
A src/gen/TCAP_RLRE-apdu.c
A src/gen/TCAP_RLRQ-apdu.c
A src/gen/TCAP_Reason.c
A src/gen/TCAP_Reject.c
A src/gen/TCAP_Release-request-reason.c
A src/gen/TCAP_Release-response-reason.c
A src/gen/TCAP_ReturnError.c
A src/gen/TCAP_ReturnErrorProblem.c
A src/gen/TCAP_ReturnResult.c
A src/gen/TCAP_ReturnResultProblem.c
A src/gen/TCAP_TCMessage.c
A src/gen/TCAP_UniDialoguePDU.c
A src/gen/TCAP_Unidirectional.c
D src/rebuild-from-asn.sh
A src/skel/ANY.c
A src/skel/ANY_ber.c
A src/skel/BIT_STRING.c
A src/skel/BIT_STRING_print.c
A src/skel/BIT_STRING_rfill.c
A src/skel/GraphicString.c
A src/skel/INTEGER.c
A src/skel/INTEGER_ber.c
A src/skel/INTEGER_print.c
A src/skel/INTEGER_rfill.c
A src/skel/NULL.c
A src/skel/NULL_ber.c
A src/skel/NULL_print.c
A src/skel/NULL_rfill.c
A src/skel/NativeInteger.c
A src/skel/NativeInteger_ber.c
A src/skel/NativeInteger_print.c
A src/skel/NativeInteger_rfill.c
A src/skel/OBJECT_IDENTIFIER.c
A src/skel/OBJECT_IDENTIFIER_print.c
A src/skel/OBJECT_IDENTIFIER_rfill.c
A src/skel/OCTET_STRING.c
A src/skel/OCTET_STRING_ber.c
A src/skel/OCTET_STRING_print.c
A src/skel/OCTET_STRING_rfill.c
A src/skel/OPEN_TYPE.c
A src/skel/OPEN_TYPE_ber.c
A src/skel/ObjectDescriptor.c
A src/skel/asn_SEQUENCE_OF.c
A src/skel/asn_SET_OF.c
A src/skel/asn_application.c
A src/skel/asn_bit_data.c
A src/skel/asn_codecs_prim.c
A src/skel/asn_codecs_prim_ber.c
A src/skel/asn_internal.c
A src/skel/asn_random_fill.c
A src/skel/ber_decoder.c
A src/skel/ber_tlv_length.c
A src/skel/ber_tlv_tag.c
A src/skel/constr_CHOICE.c
A src/skel/constr_CHOICE_ber.c
A src/skel/constr_CHOICE_print.c
A src/skel/constr_CHOICE_rfill.c
A src/skel/constr_SEQUENCE.c
A src/skel/constr_SEQUENCE_OF.c
A src/skel/constr_SEQUENCE_OF_ber.c
A src/skel/constr_SEQUENCE_ber.c
A src/skel/constr_SEQUENCE_print.c
A src/skel/constr_SEQUENCE_rfill.c
A src/skel/constr_SET_OF.c
A src/skel/constr_SET_OF_ber.c
A src/skel/constr_SET_OF_print.c
A src/skel/constr_SET_OF_rfill.c
A src/skel/constr_TYPE.c
A src/skel/constraints.c
A src/skel/der_encoder.c
268 files changed, 19,774 insertions(+), 6,301 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/22/41022/6
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>