Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-iuh/+/30142
)
Change subject: ranap_common_cn: remove unused ctx args
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
IMHO you shouldn't drop the arg. […]
I'm
not dropping it from ranap_cn_rx_co and ranap_cn_rx_cl, but only from functions that these
are calling in the same file. Because these functions don't use ctx at all, so imho
having it there just makes the whole code more confusing as it's not clear whether ctx
is for userdata or a talloc context when looking only at parts of it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-iuh/+/30142
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I8936197d7ae7ffddbe8ee99d909d74ac5b3ab227
Gerrit-Change-Number: 30142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Nov 2022 12:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment