fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39523?usp=email )
Change subject: erab_fsm: make erab_release_{cmd,ind}/1 non-blocking
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39523/comment/e0d5f266_f730…
:
PS1, Line 9: There's no practical benefit(s) in blocking the caller while waiting
specially since doing this while tons of sessions are
allocated can take in the order of 100-200ms : […]
Indeed. The current blocking
behavior looked logical at the early development stages, but reports from the field show
the opposite :)
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If519334359c3ef331720cb87bdba2d969601816e
Gerrit-Change-Number: 39523
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Feb 2025 18:32:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>