Attention is currently required from: arehbein, laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33193 )
Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
......................................................................
Patch Set 2:
(3 comments)
File include/osmocom/netif/stream.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7966):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/66fa5003_f54295aa
PS2, Line 83: void osmo_stream_cli_set_iofd_read_cb(struct osmo_stream_cli *cli, int
(*read_cb)(struct osmo_stream_cli *cli, struct msgb* msg));
"foo* bar" should be "foo *bar"
File src/stream.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7966):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/0801d1af_aa8fe9b0
PS2, Line 935: int (*read_cb)(struct osmo_stream_cli *cli, struct msgb* msg))
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7966):
https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/25a0cf0e_2a1cc405
PS2, Line 1713: }
void function return statements are not generally useful
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33193
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c
Gerrit-Change-Number: 33193
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment