4 Dec
2023
4 Dec
'23
10:02 a.m.
Attention is currently required from: fixeria, jolly, neels, osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email )
Change subject: soft_uart: implement modem status lines and flow control ......................................................................
Patch Set 4:
(1 comment)
File src/core/soft_uart.c:
https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/ce198901_6623f571 PS2, Line 398: if (active) /* assert the given line */
re: if assert and de-assert is terminology from the matching spec, then of course keep using those […]
[de]asserting a logical signal is perfectly normal language in lots of [digital] electronics texts, everywhere.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48
Gerrit-Change-Number: 35172
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: jolly andreas@eversberg.eu
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 04 Dec 2023 09:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment