Attention is currently required from: pespin, fixeria.
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 15:
(2 comments)
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ba4b5e2_ccce5e14
PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS)
-DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
The reason I had in mind here is not about changing
dir structure, it's more about whether this rela […]
I'm not aware of any
issues, the compiler also has to find all the relative paths to source files and included
local headers which are not being copied to build dirs either, so i'd expect that only
the output path gets adjusted for other build dirs, not the working dir.
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8a83b76_db58ce0b
PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
By done you mean you disabled it by default?
only used for debugging, i think i already pointed that out somewhere..
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 15
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Dec 2022 08:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment