Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email )
Change subject: core: guard TCP stats on availability of linux/tcp.h ......................................................................
Patch Set 3:
(2 comments)
File src/core/stats_tcp.c:
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/2d17a05b_37c36713?u... : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0);
I stats are not used, we should disable this too.
Done. I reworked it as suggested: the implementation is now wrapped in HAVE_LINUX_TCP_H, with stub implementations for the public APIs returning -ENOTSUP when the header is unavailable.
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/0ced7f91_008946c3?u... : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL);
I stats are not used, we can disable this function completelly afaiu.
Done. I reworked it as suggested: the implementation is now wrapped in HAVE_LINUX_TCP_H, with stub implementations for the public APIs returning -ENOTSUP when the header is unavailable.